Performance improvements for large playback queues #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This significantly reduces the memory usage
The batch api is a lot faster when inserting many of items
r1sim
changed the title
Member
|
Recently i got a crash report that may be related to this and already tracked here #55. I’ll look into it, thanks! |
Member
|
added your commit into #87, will check on testflight/app store version soon. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing a song from the song list currently queues the entire library. My library contains ~3.5k tracks which caused me some performance issues. The queuing process caused the app to freeze for several seconds, and afterward, it took roughly 15 seconds to restart while using up to 1.2gb of memory.
I fixed this by using a batch api in
addToQueueand replacing the playback queueVStackwith aLazyVStack. After optimization, memory usage dropped to ~40mb and launch time decreased to under a second on my iPhone 12 running iOS26.